Skip to content

Use isBlocked() to stop addresses from receiving Ð #209

Merged
merged 3 commits into from Jun 10, 2016

3 participants

@GriffGreen

This is to prevent users from locking up tokens that they want to vote with accidentally when they transfer them to their wallets. it will forsce them to Create a new wallet...

This is a suggestion and should be thought about further.... It fixes this issue, preventing users from sending tokens to addresses that are locked, but it also requires them to practice good key and password management (backing up their new private keys and remembering their passwords) this is not a no brainer.

@GriffGreen GriffGreen Merge pull request #2 from slockit/master
h
e6dc1eb
@LefterisJP
LefterisJP commented Jun 2, 2016 edited

Yep I like the idea, we can leave the PR open, no hurry anyway, and I should add a test for this check too. Preferrably in this PR, before it gets merged.

@GriffGreen

:-) I feel so cool adding features like I know what I'm doing ;-)

Griff Green and others added some commits Jun 9, 2016
Griff Green Merge branch 'master' of https://github.com/slockit/DAO 3283c63
@GriffGreen GriffGreen Use isBlocked() to stop addresses from receiving Ð
This is to prevent users from locking up tokens that they want to vote with accidentally when they transfer them to their wallets. it will forsce them to Create a new wallet...

This is a suggestion and should be thought about further.... It fixes this issue, preventing users from sending tokens to addresses that are locked, but it also requires them to practice good key and password management (backing up their new private keys and remembering their passwords) this is not a no brainer.
56d2875
@CJentzsch CJentzsch merged commit c014af1 into slockit:master Jun 10, 2016

1 check passed

Details continuous-integration/travis-ci/pr The Travis CI build passed
@LefterisJP LefterisJP added this to the DAO v1.1 milestone Jun 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.