Avoid thread kill via panic #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Seems reasonable. |
Author
|
@dpc Hope so. Should I take any other action with this PR? |
Contributor
|
Ping @Techcable |
Author
|
@Techcable, hello! Sorry for disturbing. Could you please review this PR? I've already sent you email about it. |
Member
I am so sorry about the slow response. Unfortunately, I was having some trouble with school which made it tough to review PRs. I will merge this right away now :) |
Author
Thank you very much! (= |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have encountered a situation when the inner task of async drain had been killed with a panic due to lack of free space on the device. It would be great to see some useful infromation about this case when it happens and have the thread stopped more gracefully. Changes provided within this PR are intended to help with described issues.
eprintlnis used to output information about encountered errors since the intended way of logging obviously doesn't work correctly in related cases.