Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the certificates for the pod-annotate example #53

Merged
merged 2 commits into from Mar 9, 2020

Conversation

@soorena776
Copy link
Contributor

soorena776 commented Feb 23, 2020

  • Replacing the expired certificate with a new one (10 years expiry date)
  • Adding a Dockerfile, and updating the Readme
  • Updating the outdated Deployment version and fields
Signed-off-by: Javad Taheri <taheri.javad@gmail.com>
@soorena776 soorena776 requested a review from slok as a code owner Feb 23, 2020
@soorena776 soorena776 force-pushed the soorena776:podannotate_certs_update_dockerfile branch from cca0745 to aef7e08 Feb 23, 2020
Signed-off-by: Javad Taheri <taheri.javad@gmail.com>
@soorena776 soorena776 force-pushed the soorena776:podannotate_certs_update_dockerfile branch from aef7e08 to c5d844c Feb 23, 2020
@slok

This comment has been minimized.

Copy link
Owner

slok commented Feb 23, 2020

Hi @soorena776, Thanks for updating the examples!

One question, Why did you created a new Dockerfile instead of using https://github.com/slok/kubewebhook/blob/master/examples/Dockerfile ?

@slok slok self-assigned this Feb 23, 2020
@soorena776

This comment has been minimized.

Copy link
Contributor Author

soorena776 commented Feb 23, 2020

Hey @slok!
I didn't notice that Dockerfile until now. Maybe the Reademe.md should be updated to clearly point to it. Just removed the last commit in the PR.

@soorena776 soorena776 force-pushed the soorena776:podannotate_certs_update_dockerfile branch from c5d844c to b0baf17 Feb 23, 2020
@soorena776

This comment has been minimized.

Copy link
Contributor Author

soorena776 commented Mar 9, 2020

@slok ptal!

@slok

This comment has been minimized.

Copy link
Owner

slok commented Mar 9, 2020

Hey @soorena776 Thanks for the heads-up! and sorry about that... I mossed and forget the PR :/

@slok
slok approved these changes Mar 9, 2020
@slok slok merged commit b199bab into slok:master Mar 9, 2020
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.