New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose assessments from pattern analyzer #170

Merged
merged 3 commits into from Dec 2, 2017

Conversation

Projects
None yet
2 participants
@jeffakolb
Collaborator

jeffakolb commented Jun 27, 2017

new BaseBlob method sentiment_assessments
new optional flag to PatternAnalyzer.analyze

Expose assessments from pattern analyzer
new BaseBlob method `sentiment_assessments`
new optional flag to PatternAnalyzer.analyze
@sloria

This comment has been minimized.

Owner

sloria commented Nov 11, 2017

Thanks for the PR @jeffakolb . I am open to merging this. Just a couple things.

  • Add tests
  • Add yourself to AUTHORS.rst

Once those are addressed, this should be good to merge.

@jeffakolb

This comment has been minimized.

Collaborator

jeffakolb commented Nov 30, 2017

@sloria Added tests and contributor entry, as requested.

@sloria

This comment has been minimized.

Owner

sloria commented Nov 30, 2017

@jeffakolb Thanks! Would you mind getting this up to date with the dev branch pls?

@jeffakolb

This comment has been minimized.

Collaborator

jeffakolb commented Nov 30, 2017

@sloria done

@sloria sloria merged commit ef26d64 into sloria:dev Dec 2, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sloria

This comment has been minimized.

Owner

sloria commented Dec 2, 2017

By the way, I'm starting to use something along the lines of the Pull Request Hack. Basically, if you get a PR merged in, you get an invite to have commit access.

No pressure to do any more work than you already have. Just want to open the door to further collaboration. =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment