Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when word string type after pos_tags is not str #255

Merged

Conversation

roman-y-korolev
Copy link

@roman-y-korolev roman-y-korolev commented Feb 7, 2019

After pos_tags word.string of all words in result have type "word", not str. If you need call str method of word.string (translate, for example) then you will call word's method.

@sloria sloria merged commit 20a3cd9 into sloria:dev Feb 24, 2019
@sloria
Copy link
Owner

@sloria sloria commented Feb 24, 2019

Thanks!

- Jamie Moschella `@jammmo <https://github.com/jammmo>`_
- Roman Korolev `@jammmo <https://github.com/roman-y-korolev>`_
Copy link
Author

@roman-y-korolev roman-y-korolev Feb 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding to the authors list. But my github nickname is just boring "roman-y-korolev" :-) Not "jammo"

Copy link
Owner

@sloria sloria Feb 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right. Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants