Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When looking for a specific file, working recursively should be possible #96

Closed
ribeaud opened this issue Aug 6, 2019 · 3 comments

Comments

@ribeaud
Copy link
Contributor

commented Aug 6, 2019

Up to the documentation, it is possible to read a specific file:

env = Env()
env.read_env(".env.test", recurse=False)

If I switch recursive to True, then it will look for .env file and NOT for the file specified as first argument (path), making recursion useless in such cases.

@sloria

This comment has been minimized.

Copy link
Owner

commented Aug 7, 2019

Thanks for reporting. PRs welcome to address this.

sloria added a commit that referenced this issue Aug 8, 2019
[#96] Recursion with custom file NOT possible (#97)
* [#96] Recursion with custom file NOT possible

* [#96] Tests seem to run at project root directory

* [#96] Revert change

* [#96] Improve sanity checks

* [#96] Fix tox error

* Minor test cleanup; remove comment

* Update changelog
@sloria

This comment has been minimized.

Copy link
Owner

commented Aug 8, 2019

Thanks again for the PR. It's released in 5.2.1

@sloria sloria closed this Aug 8, 2019

@ribeaud

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2019

Hi @sloria. Unfortunately, the fix I've provided does NOT work. I did NOT test enough resp. it is not so easy to test. I will open an new issue and relate it to that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.