Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the caller to control whether read_env will recurse. #9

Merged
merged 1 commit into from Jan 25, 2018

Conversation

@gthank
Copy link

commented Jan 24, 2018

The underlying library already exposes a flag to control this behavior,
so I'm merely adding a passthrough for that flag.

I think this flag should be exposed for the same reason it's exposed in the underlying library: it's very useful. For instance, I don't want a web service process potentially recursing up the file system out of its little "jail" (or at least trying to); it's preferable to me that it just throw an Exception. Since that's already something provided by the underlying library, it seems like a good idea to expose it here. I made the default True so the change should be backward compatible.

Allow the caller to control whether read_env will recurse.
The underlying library already exposes a flag to control this behavior,
so I'm merely adding a passthrough for that flag.
@sloria

This comment has been minimized.

Copy link
Owner

commented Jan 25, 2018

Makes sense to me. Thanks!

@sloria sloria merged commit 67b0ff9 into sloria:master Jan 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.