Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matchPages wrong when there's collection-if based on parameters #27

Closed
slovnicki opened this issue Jan 23, 2021 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@slovnicki
Copy link
Owner

slovnicki commented Jan 23, 2021

example

class BooksLocation extends BeamLocation {
  @override
  List<Page> get pages => [
        ...HomeLocation().pages,
        BeamPage(
          key: ValueKey('books-${queryParameters['title'] ?? ''}'),
          page: BooksScreen(),
        ),
        if (pathParameters.containsKey('id'))
          BeamPage(
            key: ValueKey('book-${pathParameters['id']}'),
            page: BookDetailsScreen(
              book: books[int.parse(pathParameters['id'])],
            ),
          ),
      ];

  @override
  String get pathBlueprint => '/books/:id';
}

and then pop from details screen

@slovnicki slovnicki added the bug Something isn't working label Jan 23, 2021
@slovnicki slovnicki self-assigned this Jan 23, 2021
@slovnicki
Copy link
Owner Author

temporarily fixed by ignoring location's parameters. Better solution is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant