Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Important change for future 'grid' development #141

Closed
pmur002 opened this issue Sep 13, 2019 · 1 comment
Closed

Important change for future 'grid' development #141

pmur002 opened this issue Sep 13, 2019 · 1 comment

Comments

@pmur002
Copy link

pmur002 commented Sep 13, 2019

Summary

There is one use of class(x) == "unit" in to_unit() that should be replaced by is.unit(x)

Minimal code example

The problem is not apparent in any released or development version of R; it was "revealed" by R CMD check testing on a new implementation of 'grid' units thomasp85/grid#14

The change should work with current 'grid'/R as well as future-proofing for further development.
@pmur002 pmur002 mentioned this issue Sep 13, 2019
Closed
23 tasks
@slowkow
Copy link
Owner

slowkow commented Sep 16, 2019

Thank you for reporting this and providing the fix :)

slowkow added a commit that referenced this issue Oct 29, 2019
@slowkow
fix issue #141
72bdd55 
Use `is.unit(x)` instead of `class(x) == "unit"`
@slowkow slowkow closed this as completed Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slowkow @pmur002