Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSetting random number generator #73
Comments
|
Hi Marko, Thanks for reporting this issue, and thanks for the kind words. I hadn't considered the side effects of setting the random seed inside It would be helpful to write a minimal code example that demonstrates the problem. I'd greatly appreciate if you can share such a code example. Could I please ask you to post your session info with the following command? I need to know what version of ggrepel is affected by this problem. devtools::session_info()A note for myself: in commit 0b0a7ab I set the seed to a random number, and this was done to fix issue #33. |
|
There seem to be an issue with some of the other packages I am using (modifying the .Random.seed directly and not via set.seed function). By doing a clean install your package works as it should. Sorry for troubling you. |
checking that issue slowkow#73 is resolved
Dear Kamil,
I really like the package, it does a great job.
I noticed that as a side effect of every call to geom_text_repel the seed of the random number generator is reset to a fixed value. This is a potentially dangerous side effect which, in my case, is causing deterministic behavior of the program, where it should be stochastic. Once one knows about it it is not difficult to fix this behavior, but it can lead to difficult to find bugs in the code. Please, can you fix this.
Best regards,
Marko