Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upupdate ggproto defaults to fix #72 #74
Conversation
This originated with #67. The xlim and ylim did not have defaults. This wasn't picked up in the package itself because these defaults were provided in the `geom_*_repel()` functions. If a function is provided that doesn't explicitly set xlim and ylim, the ggproto goes into an infinite loop.
|
Zhian, thank you again for the excellent work here! I really appreciate it. You are now a contributor |
This originated with #67. The xlim and ylim did not have defaults. This wasn't picked up in the package itself because these defaults were provided in the
geom_*_repel()functions. If a function is provided that doesn't explicitly set xlim and ylim, the ggproto goes into an infinite loop.Here's an example that would fail without this PR:
Session info