fix: fix error logs#356
Merged
asraa merged 1 commit intoslsa-framework:mainfrom Nov 11, 2022
suzuki-shunsuke:fix-error-log
Merged
fix: fix error logs#356asraa merged 1 commit intoslsa-framework:mainfrom suzuki-shunsuke:fix-error-log
asraa merged 1 commit intoslsa-framework:mainfrom
suzuki-shunsuke:fix-error-log
Conversation
Contributor
Author
|
I think this is a trivial bug fix so an issue is unneeded, but if an issue is needed please let me know. |
ianlewis
approved these changes
Nov 11, 2022
ramonpetgrave64
pushed a commit
to ramonpetgrave64/slsa-verifier
that referenced
this pull request
Apr 18, 2024
Co-authored-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix error logs.
I guess these codes are copied from the just before error handling mistakenly.
slsa-verifier/verifiers/internal/gha/rekor.go
Line 81 in 137528a