Simplify the specifications list template. #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for slsa ready! 🔨 Explore the source changes: ede4666 🔍 Inspect the deploy log: https://app.netlify.com/sites/slsa/deploys/61e82709a37a000007c01c4e 😎 Browse the preview: https://deploy-preview-271--slsa.netlify.app |
Similar to e56c388 (slsa-framework#270), but for the list of subpages in /spec/v0.1/index. This change replace the "automatic" code with a manual list, which is much easier to understand and maintain. No content change. The only HTML change is to switch from absolute to relative links and to eliminate empty `<li>` elements. NOTE: Neither the original nor new code correctly handled displaying more than one specification version. This commit adds a TODO making it clear that it doesn't work. Signed-off-by: Mark Lodato <lodato@google.com>
trishankatdatadog
approved these changes
Jan 19, 2022
|
Thanks for the quick reviews! |
|
How do we block @NANOKINGJOKER? |
Already done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to e56c388 (#270), but for the list of subpages in /spec/v0.1/index. This change replace the "automatic" code with a manual list, which is much easier to understand and maintain.
No content change. The only HTML change is to switch from absolute to relative links and to eliminate empty
<li>elements.NOTE: Neither the original nor new code correctly handled displaying more than one specification version. This commit adds a TODO making it clear that it doesn't work.
Testing
The old and new version result in identical HTML except as noted above, ignoring one whitespace change and build timestamps on posts.
Compare: