UI fixes #910
Merged
UI fixes #910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alashchev17
reviewed
Dec 1, 2025
Member
alashchev17
left a comment
alashchev17
left a comment
There was a problem hiding this comment.
LGTM
Will push a small fix and it's good to be merged 👍
The package-lock.json is missing platform-specific optional dependencies (like fsevents, @parcel/watcher-*, @esbuild/* packages) because it was generated on Linux. npm ci is strict and fails when these are missing. Using npm install --prefer-offline instead allows the build to proceed while still respecting the lock file for version resolution.
JegernOUTT
force-pushed
the
sergei-fixes-cvox
branch
from
2f35abb to
33b80aa
Compare
localStorage is not available in Node.js test environment. Added checks to prevent accessing localStorage when it's undefined, which fixes the 'localStorage.getItem is not a function' test errors.
Mock localStorage in test setup to fix 'localStorage.getItem is not a function' errors. The happy-dom environment doesn't provide a fully functional localStorage by default.
Add typeof check for localStorage.getItem to handle cases where localStorage exists but doesn't have the getItem method (can happen during test setup timing).
Add missing Storage interface properties (key, length) to make the mock fully compatible with the Storage type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.