Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Optional for the config properties with the default values #379

Merged
merged 1 commit into from Jan 13, 2021
Merged

Remove Optional for the config properties with the default values #379

merged 1 commit into from Jan 13, 2021

Conversation

sberyozkin
Copy link
Contributor

This is the last PR which I'd like to target at the mpjwt12 branch. It updates JwtAuthContextInfoProvider and:

  • removes Optional where possible (Mike - thanks for pointing it earlier on)
  • removes the redundant getters - they do not even cover all the properties - they were originally intended for Thorntail and even there there were not property integrated as far as I recall
  • drops the deprecated property which has already been deprecated in the 2.x line

@sberyozkin sberyozkin added this to the 3.0.0 milestone Jan 12, 2021
@sberyozkin
Copy link
Contributor Author

This is just some cleanup so going ahead with Roberto approving

@sberyozkin sberyozkin merged commit e703c6f into smallrye:mpjwt12 Jan 13, 2021
@sberyozkin sberyozkin deleted the remove_optional_where_default_is_available branch January 13, 2021 09:58
@sberyozkin sberyozkin mentioned this pull request Jan 13, 2021
Closed
@sberyozkin sberyozkin restored the remove_optional_where_default_is_available branch January 15, 2021 22:55
@sberyozkin sberyozkin mentioned this pull request Jan 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radcortez radcortez radcortez approved these changes

@darranl darranl Awaiting requested review from darranl

@MikeEdgar MikeEdgar Awaiting requested review from MikeEdgar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sberyozkin @radcortez