New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - SMAP 17.12 - TRANSIFEX Error Message #160

Closed
atl2017 opened this Issue Jan 6, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@atl2017

atl2017 commented Jan 6, 2018

SmapServer

Version 17.12

Expected Behaviour

Actual Behaviour: space and variable missing in message (either englisg and spanish)

image

@atl2017

This comment has been minimized.

Show comment
Hide comment
@atl2017

atl2017 Jan 7, 2018

I tested again and do not produce any message no matter error is still present:

image

Project: TestAlex
Form: TestCSVMultiple3

In choices sheet there is

image

and in the csv file there are no header with this name:

image

atl2017 commented Jan 7, 2018

I tested again and do not produce any message no matter error is still present:

image

Project: TestAlex
Form: TestCSVMultiple3

In choices sheet there is

image

and in the csv file there are no header with this name:

image

@nap2000

This comment has been minimized.

Show comment
Hide comment
@nap2000

nap2000 Jan 7, 2018

Contributor

Yes. I made a modification to just send the error to the log. My thinking was that it may not be a real errors as the intention maybe to edit the csv later. If upload supported warnings then this might be appropriate but it doesn't at the moment.

However on reflection I think this should be reported as an error. Loading an xls form that references a CSV file that does not exist is ok (maybe should also be a warning) as the expectation would be that the CSV file will be loaded next. However if the CSV file is already there and it does not match then its probably a mistake. So I will add the error report back in.

Contributor

nap2000 commented Jan 7, 2018

Yes. I made a modification to just send the error to the log. My thinking was that it may not be a real errors as the intention maybe to edit the csv later. If upload supported warnings then this might be appropriate but it doesn't at the moment.

However on reflection I think this should be reported as an error. Loading an xls form that references a CSV file that does not exist is ok (maybe should also be a warning) as the expectation would be that the CSV file will be loaded next. However if the CSV file is already there and it does not match then its probably a mistake. So I will add the error report back in.

@nap2000 nap2000 self-assigned this Jan 8, 2018

@nap2000

This comment has been minimized.

Show comment
Hide comment
@nap2000

nap2000 Jan 8, 2018

Contributor

I've added a warning message for when the CSV files exist but the references from the xlsform do not match the columns in the CSV file.

Contributor

nap2000 commented Jan 8, 2018

I've added a warning message for when the CSV files exist but the references from the xlsform do not match the columns in the CSV file.

@atl2017

This comment has been minimized.

Show comment
Hide comment
@atl2017

atl2017 Jan 9, 2018

tested OK

image

atl2017 commented Jan 9, 2018

tested OK

image

@atl2017 atl2017 closed this Jan 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment