Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Exception signaling #214

Closed
daumayr opened this issue Jan 17, 2018 · 2 comments

Comments

3 participants
@daumayr
Copy link
Contributor

commented Jan 17, 2018

Build a nice exception thrower in Java to avoid helpers in SOMns code.
Introduction of new Exception classes (and throwing them from the Java side) should be clean and easy to do.

@smarr

This comment has been minimized.

Copy link
Owner

commented Jan 24, 2018

TODO:

  • make sure all signalNotAValueWith: errors and similar use only the class of the broken Value, but don't let the invalid Value object escape. We can't allow references to invalid objects to exist
  • make sure we use constant SSymbol objects everywhere, the string conversion is just overhead

@smarr smarr added this to Open Issues in Completeness Feb 14, 2018

@smarr smarr changed the title Improve Exceptions Optimize Exception signaling Feb 23, 2018

@clementbera

This comment has been minimized.

Copy link
Contributor

commented May 23, 2018

Attempted to fix in PR:
#251

@smarr smarr closed this Jun 3, 2018

Completeness automation moved this from Open Issues to Completed Jun 3, 2018

@smarr smarr added this to the v0.7.0 milestone Jul 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.