Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promises: do we remove processed messages from the promise? #294

Closed
smarr opened this issue Apr 6, 2019 · 2 comments

Comments

Projects
None yet
1 participant
@smarr
Copy link
Owner

commented Apr 6, 2019

It seems as if we never clean out the messages on the promise.
The promises should behave like inboxes, and messages that were actually sent should be cleared out to prevent memory leaks.

It should be safe to do so on resolution, because once a promise is resolved, all messages to it are sent directly to the value.

@smarr smarr added the bug label Apr 6, 2019

@smarr smarr added this to the v0.7.0 milestone Apr 6, 2019

@smarr

This comment has been minimized.

Copy link
Owner Author

commented Jul 2, 2019

@daumayr did you have a fix for this issue?

@smarr

This comment has been minimized.

Copy link
Owner Author

commented Jul 7, 2019

This was resolved with #300.

@smarr smarr closed this Jul 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.