Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Actor mailbox loop to Truffle #250

Merged
merged 8 commits into from May 16, 2018

Conversation

2 participants
@smarr
Copy link
Owner

commented May 13, 2018

This PR moves the loop that iterates over the messages in a mailbox into Truffle.
This is technically not an optimization in itself, but enables future optimization, because it gives more control over for instance tracing operations.

The PR contains also a number of smaller cleanups.

For reference, I included the code that adds caching for the methods of messages.
However, there are even for simple programs too many messages, so this is not useful, and therefore reverted.

smarr added some commits Apr 27, 2018

Add profile for whenResolved classes
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Add separate skip.truffle for ant
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Make SArray constructor protected
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Fix NPE in uncaught exception handler, and add info on thread
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Move actor execution loop over mailbox into truffle
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Replace compilation warning with boundaries
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Remove cache for messages in exec loop
- this does not seem to be beneficial (not extensively benchmarked though)
- problem is that we get too many different call targets
- so, looking through list of cached items becomes expensive

Signed-off-by: Stefan Marr <git@stefan-marr.de>
Optimize scheduling promises
Signed-off-by: Stefan Marr <git@stefan-marr.de>

@smarr smarr added the enhancement label May 13, 2018

@smarr smarr added this to the v0.7.0 milestone May 13, 2018

@smarr smarr added this to To Do in Actor Record & Replay May 13, 2018

@smarr

This comment has been minimized.

Copy link
Owner Author

commented May 13, 2018

@daumayr, I started moving some of the things we did for the paper into the main branch.
Would be great if you could have a look, and review the changes.

@daumayr

This comment has been minimized.

Copy link
Contributor

commented May 16, 2018

@smarr, I had a look on the changes, they look good to me.

@smarr smarr merged commit 0ee5495 into dev May 16, 2018

4 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 77.544%
Details

Actor Record & Replay automation moved this from To Do to Done May 16, 2018

@smarr

This comment has been minimized.

Copy link
Owner Author

commented May 16, 2018

Thank you. It's merged.

@smarr smarr deleted the actor-optimizations branch May 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.