Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Use CompilerDirectives::castExact instead of ValueProfiles #256
smarr left a comment
Thanks for the PR!
The changes look good to me.
And, updating Truffle means I need to update my Truffle changes, adapt the changes for the instrumentation, etc. Last time I tried doing that, I did not manage to get everything working again. So, will take more time.
Why shouldn't this be useful at the moment? Performance should remain the same, code is simpler? castExact will only help to remove the remaining ValueProfile. Also, we don't need to it for the plain Integer case, A cast to an unboxed int should do the trick, right?