Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure charAt: and File read/write are compatible with PE #260

Merged
merged 5 commits into from Jul 19, 2018

Conversation

2 participants
@smarr
Copy link
Owner

commented Jul 19, 2018

This PR adds microbenchmarks for String>>#charAt: and file read/write.

It also fixes basic compilation issues in file reading and writing.

@daumayr please review.

smarr added some commits Jul 19, 2018

Added a microbenchmark for String>>#charAt:
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Added benchmark for basic file reading/writing
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Optimize file reading/writing for compilation
This is only addressing the basic compilation issues, it does not do any performance tuning.

Signed-off-by: Stefan Marr <git@stefan-marr.de>

@smarr smarr added the bug label Jul 19, 2018

@smarr smarr added this to the v0.7.0 milestone Jul 19, 2018

@smarr smarr added this to Open Issues in Completeness via automation Jul 19, 2018

Update test data
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@daumayr
Copy link
Contributor

left a comment

Thanks for fixing this, changes look good

[Travis] caskroom is deprecated
Reinstall of Java failed with:

==> Downloading http://download.oracle.com/otn-pub/java/jdk/10.0.2+13/19aef61b38124481863b1413dce1855f/jdk-10.0.2_osx-x64_bin.dmg
Error: undefined method `undent' for #<String:0x000000010233a010>

Hope this fixes it

Signed-off-by: Stefan Marr <git@stefan-marr.de>

@smarr smarr force-pushed the string-and-file-compilation branch from ecc6a32 to 5f6e338 Jul 19, 2018

@smarr

This comment has been minimized.

Copy link
Owner Author

commented Jul 19, 2018

There is something broken in brew. Not sure what to do about it beside ignoring the failure for the moment. My attempts to ensure the most recent brew is installed do not seem to be sufficient.

So, will ignore the failing Travis run for now.

@smarr smarr merged commit 7dda6e2 into dev Jul 19, 2018

2 of 4 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
coverage/coveralls Coverage remained the same at 77.487%
Details

Completeness automation moved this from Open Issues to Completed Jul 19, 2018

@smarr smarr deleted the string-and-file-compilation branch Jul 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.