Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes before Truffle update #267

merged 16 commits into from Sep 1, 2018


1 participant
Copy link

commented Aug 31, 2018

This PR prepares updating Truffle by fix various issues that were found in the update process.

Most notably:

  • use parameter of step-out operation 93ad33e
  • fix wrong ActivityJoin tag c945606
  • fix initialization of transactional #at:put: 5324153
  • add some maintainability bits for extension tests dd2c09e
  • ClassSlotAccessNode: use guard in node da4d5cb
  • fix swapping of tracing buffers for Kompos 70e0c36
    @daumayr could you please review this change? (also after merging)

smarr added some commits Mar 30, 2018

Change in formatting
Signed-off-by: Stefan Marr <>
Use parameter to step out, instead of doing it manually
Signed-off-by: Stefan Marr <>
Fixed reference to wrong class as tag in ActivityJoin
Signed-off-by: Stefan Marr <>
Ignore nodes without source sections
With the latest truffle changes, source sections do not seem to be mandatory anymore, but we need only those nodes.

Signed-off-by: Stefan Marr <>
Fix initialization of transactional AtPut nodes
Didn’t indicate whether they are wrapped.

Signed-off-by: Stefan Marr <>
For uncaught exceptions, announce stack trace, and warn that itself m…
…ight crash

Signed-off-by: Stefan Marr <>
Added README, .gitignore, and checkstyle for extension tests
- clean test extension on clean

Signed-off-by: Stefan Marr <>
Mark ExtensionPrims as abstract
Signed-off-by: Stefan Marr <>
ClassSlotAccessNode: use guard in the node
Instead of accessing the read/write node for its guard, use the one cached in the node.

On construction we take this guard for easy access already. Using it directly from the node is problematic when wrappers are applied.

Signed-off-by: Stefan Marr <>
Remove redundant check and fix compiler warning about raw type
Signed-off-by: Stefan Marr <>
Handle methods that don’t have outer scope
These should be only superclass resolution methods.

Signed-off-by: Stefan Marr <>
Fix swapping of tracing buffers for Kompos
- use proper methods instead of public field to indicate the swap request
- coordinate with debugger. If a thread is blocked in a breakpoint (which triggers a trace data request) then we need to nicely swap the buffer ourselves. That’s safe of course.
- threads need to be registered to tracing backend also for Kompos

Signed-off-by: Stefan Marr <>
Add id for STM thread as debugging aid
Signed-off-by: Stefan Marr <>
Output extra data for failing tests for basic protocol
Signed-off-by: Stefan Marr <>
Remove unused ExpressionNode.assertIsStatement()
Signed-off-by: Stefan Marr <>
Use SIGKILL to terminate SOMns after test
Not sure why, but we seem to need a little more force.
Otherwise, the tests hang after completion.

Signed-off-by: Stefan Marr <>

@smarr smarr added this to the v0.7.0 milestone Aug 31, 2018

@smarr smarr self-assigned this Aug 31, 2018

@smarr smarr added this to Open Issues in Completeness via automation Aug 31, 2018

@smarr smarr merged commit 421bfc9 into dev Sep 1, 2018

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
continuous-integration/travis-ci/push The Travis CI build failed
Codacy/PR Quality Review Up to standards. A positive pull request.
coverage/coveralls Coverage remained the same at 77.509%

Completeness automation moved this from Open Issues to Completed Sep 1, 2018

@smarr smarr deleted the various-fixes branch Sep 1, 2018

@smarr smarr changed the title Various fixes Various fixes before Truffle update Sep 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.