Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replay test flakiness #268

Merged
merged 1 commit into from Sep 3, 2018

Conversation

2 participants
@daumayr
Copy link
Contributor

commented Sep 3, 2018

Exit code was changed to 1 when there were some unprocessed but expected messages at termination.
Exit code no longer touched by message check, message reports only printed when exiting with codes other than 0.

Fix teplay test flakiness
Exit code was changed to 1 when there were some unprocessed but expected messages at termination.

@smarr smarr force-pushed the daumayr:dev branch from e514d9a to 8a9b018 Sep 3, 2018

@smarr smarr added this to the v0.7.0 milestone Sep 3, 2018

@smarr smarr added this to To Do in Actor Record & Replay via automation Sep 3, 2018

@smarr smarr self-assigned this Sep 3, 2018

@smarr

smarr approved these changes Sep 3, 2018

Copy link
Owner

left a comment

Looks good to me.

The code in replayCanProcess(.) looks a little ugly. Perhaps there is a simple method hiding somewhere to make it look nicer. I won't bother in this PR though.

Thanks.

@smarr smarr merged commit af2c447 into smarr:dev Sep 3, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Actor Record & Replay automation moved this from To Do to Done Sep 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.