Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes potential NullPointerException in ExpressionNode::toString #269

Merged
merged 1 commit into from Sep 11, 2018

Conversation

2 participants
@spilot
Copy link
Contributor

commented Sep 11, 2018

The NPE is thrown when SourceSection == null

@smarr smarr changed the base branch from release to dev Sep 11, 2018

@smarr smarr added the bug label Sep 11, 2018

@smarr smarr added this to Open Issues in Completeness via automation Sep 11, 2018

@smarr smarr added this to the v0.7.0 milestone Sep 11, 2018

@smarr

smarr approved these changes Sep 11, 2018

Copy link
Owner

left a comment

Good catch. Thank you!

@smarr

This comment has been minimized.

Copy link
Owner

commented Sep 11, 2018

Just a bit on process:

I changed the base for the PR to the dev branch. Usually, we keep release unchanged, even for bug fixes. Our project isn't large enough to be able to maintain more than one branch unfortunately.

And, then a tip for using branches/github: if you would push the change to a separate branch, it is easier to iterate on more complex changes, and then simply push to that branch. After it is merged, it can also be simply deleted again. Another benefit is that your own main development branch doesn't depend on the progress of the PR.

As for this change, it looks all good. Tests simply failed, because the release branch currently fails building. Think that's an issue with missing libraries, things that moved on the internet. Checkstyle for instance.

@smarr smarr merged commit f2a5855 into smarr:dev Sep 11, 2018

0 of 2 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

Completeness automation moved this from Open Issues to Completed Sep 11, 2018

@spilot

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2018

Got it, thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.