Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixes potential NullPointerException in ExpressionNode::toString #269
Just a bit on process:
I changed the base for the PR to the
And, then a tip for using branches/github: if you would push the change to a separate branch, it is easier to iterate on more complex changes, and then simply push to that branch. After it is merged, it can also be simply deleted again. Another benefit is that your own main development branch doesn't depend on the progress of the PR.
As for this change, it looks all good. Tests simply failed, because the release branch currently fails building. Think that's an issue with missing libraries, things that moved on the internet. Checkstyle for instance.