Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update basic-setup documentation #284

Merged
merged 2 commits into from Jan 15, 2019

Conversation

2 participants
@clementbera
Copy link
Contributor

commented Jan 14, 2019

Update basic-setup to describe how to set-up the environment to ant compile the dev branch.

Java 8+JVMCI has basically to be installed and the environment variable JVMCI_HOME has to point to it for the substrate VM dependency to compile in addition to JAVA_HOME pointing to any Java version (typically Java 11).

clementbera and others added some commits Jan 14, 2019

Update basic-setup
Update basic-setup to describe how to set-up the environment to ant compile the dev branch.

Java 8+JVMCI has basically to be installed and the environment variable JVMCI_HOME has to point to it for the substrate VM dependency to compile in addition to JAVA_HOME pointing to any Java version (typically Java 11).
Reformatting for max 80 char line limit, and minor edits
Signed-off-by: Stefan Marr <git@stefan-marr.de>

@smarr smarr self-assigned this Jan 14, 2019

@smarr smarr added the enhancement label Jan 14, 2019

@smarr smarr added this to Open Issues in Completeness via automation Jan 14, 2019

@smarr smarr added this to the v0.7.0 milestone Jan 14, 2019

@smarr

This comment has been minimized.

Copy link
Owner

commented Jan 14, 2019

Thanks for the PR! If my reformatting/editing is ok with you, I'll merge the PR.

@clementbera

This comment has been minimized.

Copy link
Contributor Author

commented Jan 15, 2019

It's ok, you can merge.

@smarr smarr changed the title Update basic-setup Update basic-setup documentation Jan 15, 2019

@smarr smarr merged commit 5c5ccc8 into smarr:dev Jan 15, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Completeness automation moved this from Open Issues to Completed Jan 15, 2019

@smarr

This comment has been minimized.

Copy link
Owner

commented Jan 15, 2019

Thanks a lot for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.