Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocking primitives cannot participate in safepoints #288

Merged
merged 1 commit into from Jan 16, 2019

Conversation

2 participants
@smarr
Copy link
Owner

commented Jan 16, 2019

Adapt all known blocking primitives to unregister before, and reregister after a safepoint.

@daumayr could you have a look and see whether this fixes your issues?

We don't have benchmarks evaluating this change, so, I think, correctness is key, and if performance becomes an issue, we need to find more specific strategies, or optimizations for special cases.

For blocking primitives, do not participate in safepoints
Signed-off-by: Stefan Marr <git@stefan-marr.de>

@smarr smarr added the bug label Jan 16, 2019

@smarr smarr added this to the v0.7.0 milestone Jan 16, 2019

@smarr smarr self-assigned this Jan 16, 2019

@smarr smarr added this to Open Issues in Completeness via automation Jan 16, 2019

@daumayr

This comment has been minimized.

Copy link
Contributor

commented Jan 16, 2019

@smarr, this fix resolves the issues in the LeeTM and Vacation Benchmarks.

@smarr

This comment has been minimized.

Copy link
Owner Author

commented Jan 16, 2019

So, changes look good?
Want me to merge this one?

@daumayr

This comment has been minimized.

Copy link
Contributor

commented Jan 16, 2019

yes please, this would reduce the number of branches and PRs

@smarr smarr changed the title Blocking primitives can't not participate in safepoints Blocking primitives cannot participate in safepoints Jan 16, 2019

@smarr smarr merged commit f4006fb into dev Jan 16, 2019

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/gitlab/git.cs.kent.ac.uk Pipeline passed on GitLab
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 76.582%
Details

Completeness automation moved this from Open Issues to Completed Jan 16, 2019

@smarr smarr deleted the blocking-prims-and-safepoints branch Jan 16, 2019

@smarr

This comment has been minimized.

Copy link
Owner Author

commented Feb 1, 2019

This fixed #286.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.