Blocking primitives cannot participate in safepoints #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Marr <git@stefan-marr.de>
|
@smarr, this fix resolves the issues in the LeeTM and Vacation Benchmarks. |
|
So, changes look good? |
|
yes please, this would reduce the number of branches and PRs |
smarr
changed the title
|
This fixed #286. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt all known blocking primitives to unregister before, and reregister after a safepoint.
@daumayr could you have a look and see whether this fixes your issues?
We don't have benchmarks evaluating this change, so, I think, correctness is key, and if performance becomes an issue, we need to find more specific strategies, or optimizations for special cases.