Allow cre sdk tests to be optional if they aren't released yet.#2133
Merged
Conversation
…enables testing on capabilites-dev while still allowing the standard tests to evolve for main if a feature isn't released
|
👋 nolag, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the WASM “standard test” harness able to treat some SDK-backed tests as optional, so environments where a capability/test hasn’t been released yet (e.g., capabilities-dev) can still run the rest of the suite.
Changes:
- Switch
TestStandardTeeRuntimeto build its WASM module using an “optional” helper. - Add
makeOptionalTestModuleWithConfigand extend the module builder to optionally skip when the test module cannot be built.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📊 API Diff Results
|
…. This means if you intend to implment it you can still fail if complication fails
russell-stern
approved these changes
Jun 8, 2026
bolekk
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables testing on capabilites-dev while still allowing the standard tests to evolve for main if a feature isn't released