Add privacy + foundations as CODEOWNERS for confidentialrelay#2135
Open
nadahalli wants to merge 2 commits into
Open
Add privacy + foundations as CODEOWNERS for confidentialrelay#2135nadahalli wants to merge 2 commits into
nadahalli wants to merge 2 commits into
Conversation
confidentialrelay carries the relay-DON authorization logic (PRIV-433), which is privacy-owned security code, but it currently falls under the catch-all foundations owner. Add an explicit entry so privacy reviews are required, mirroring the existing confidentialhttp and teeattestation entries.
|
👋 nadahalli, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an explicit CODEOWNERS rule for the confidentialrelay action package so that reviews require the intended ownership teams (privacy + foundations), aligning ownership expectations for security-sensitive relay authorization logic.
Changes:
- Add a CODEOWNERS entry for
/pkg/capabilities/v2/actions/confidentialrelayassigning@smartcontractkit/privacyand@smartcontractkit/foundations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pavel-raykov
previously approved these changes
Jun 8, 2026
Match confidentialhttp: confidentialrelay is purely privacy's code, so assign it to @smartcontractkit/privacy outright rather than co-owning with foundations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
confidentialrelay holds the relay-DON authorization logic (PRIV-433), which is privacy-owned security code. It currently has no specific CODEOWNERS entry, so it falls under the catch-all @smartcontractkit/foundations and privacy reviews are not required (e.g. #2109 cannot be approved by privacy as a code owner).
This adds an explicit entry assigning it to @smartcontractkit/privacy @smartcontractkit/foundations, mirroring the existing confidentialhttp (privacy) and teeattestation (privacy + foundations) entries.