Send metrics to loki with each new event (transmitted, committed, executed#16862
Merged
asoliman92 merged 3 commits intodevelopfrom Mar 21, 2025
Merged
Send metrics to loki with each new event (transmitted, committed, executed#16862asoliman92 merged 3 commits intodevelopfrom
asoliman92 merged 3 commits intodevelopfrom
Conversation
…cuted) This will help us understand how many messages per lane passed each state
asoliman92
requested review from
0xAustinWang,
b-gopalswami,
dimkouv,
makramkd,
matYang,
mateusz-sekara and
winder
|
mateusz-sekara
approved these changes
Mar 21, 2025
makramkd
approved these changes
Mar 21, 2025
| // only add commit and exec durations if we have correct timestamps to calculate them | ||
| commitDuration := uint64(0) | ||
| if state.timestamps[committed] != 0 && state.timestamps[transmitted] != 0 { | ||
| commitDuration = state.timestamps[committed] - state.timestamps[transmitted] |
Contributor
There was a problem hiding this comment.
What does transmitted mean here? When the message is finalized on the source chain?
Contributor
Author
There was a problem hiding this comment.
message successfully sent not finalized
Contributor
There was a problem hiding this comment.
Then I don't think this is the right metric, it should be from finalized -> committed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Send metrics to loki with each new event (transmitted, committed, executed
This will help us understand how many messages per lane passed each state during run time.
Added log fields (failed_commit and failed_exec) that we populate when we timeout waiting for messages after the load is finished. In a subsequent PR we can reuse them to get some data about failed messages during the run not at the end of it.