test: remove test_helpers.Apply functions#65
Conversation
|
👋 jkongie, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
There was a problem hiding this comment.
Pull request overview
This PR removes the Apply/Configure test helper APIs from pkg/cldfutil/changeset (since they should not be part of the public API) and updates affected tests to execute changesets via the test runtime (runtime.Exec / runtime.ChangesetTask).
Changes:
- Deleted the
ConfiguredChangeSet/Configure/Apply/ApplyChangesetshelpers frompkg/cldfutil/changeset/test_helpers.go. - Updated EVM operations and MCMS+Timelock tests to execute changesets through the
engine/test/runtimetask runner. - Adjusted tests to read environments from the runtime rather than from the removed helpers.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pkg/family/evm/operations/utils_test.go | Replaces use of removed changeset helpers with runtime.Exec(runtime.ChangesetTask(...)) and uses rt.Environment() for state loading. |
| pkg/cldfutil/changeset/test_helpers.go | Removes the Apply/Configure helper APIs, leaving only LINK funding/balance helpers. |
| legacy/mcms/changesets/deploy_mcms_with_timelock_test.go | Migrates the test to runtime-based changeset execution, but currently contains environment/state handling issues. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jkongie
changed the title
jkongie
force-pushed
the
remove-test-apply-functions
branch
from
b2a41ef to
c411f5b
Compare
Removes tests `Apply functions` from test helpers and updates the tests. This function should not have been part of the public API.
jkongie
force-pushed
the
remove-test-apply-functions
branch
from
c411f5b to
5f4bbbf
Compare
|
| ) | ||
| require.NoError(t, err) | ||
| mcmsState, err = evmstate.MaybeLoadMCMSWithTimelockState(updatedEnv, []uint64{selector}) | ||
|
|
| @@ -201,19 +199,18 @@ func TestAddEVMCallSequenceToCSOutput_ProposalCombination(t *testing.T) { | |||
|
|
|||
| // Deploy MCMS+Timelock to both chains. Real deployments are required because | |||
| // AddEVMCallSequenceToCSOutput → BuildProposalFromBatchesV2 reads OpCount from | |||
Removes tests
Apply functionsfrom test helpers and updates the tests.This function should not have been part of the public API.