From 6ade369d46afc255e637c6b88af2a1b070d6a0d0 Mon Sep 17 00:00:00 2001 From: anirudhwarrier <12178754+anirudhwarrier@users.noreply.github.com> Date: Fri, 22 May 2026 18:26:17 +0400 Subject: [PATCH 1/2] Refactor input validation in UpsertWorkflow function --- .../client/privateregistryclient/privateregistryclient.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/internal/client/privateregistryclient/privateregistryclient.go b/internal/client/privateregistryclient/privateregistryclient.go index 6e9d9e9d..1c5875fe 100644 --- a/internal/client/privateregistryclient/privateregistryclient.go +++ b/internal/client/privateregistryclient/privateregistryclient.go @@ -349,10 +349,8 @@ func validateUpsertWorkflowInput(input OffchainWorkflowInput) error { if input.Status == "" { return fmt.Errorf("status is required") } - if input.Status != WorkflowStatusUnspecified && - input.Status != WorkflowStatusActive && - input.Status != WorkflowStatusPaused { - return fmt.Errorf("status must be one of %q, %q, %q", WorkflowStatusUnspecified, WorkflowStatusActive, WorkflowStatusPaused) + if input.Status != WorkflowStatusActive && input.Status != WorkflowStatusPaused { + return fmt.Errorf("status must be one of %q, %q", WorkflowStatusActive, WorkflowStatusPaused) } if input.WorkflowName == "" { return fmt.Errorf("workflowName is required") From be043868ee7b39b5a35f1b008b67a5f1daf10f41 Mon Sep 17 00:00:00 2001 From: anirudhwarrier <12178754+anirudhwarrier@users.noreply.github.com> Date: Fri, 22 May 2026 18:39:28 +0400 Subject: [PATCH 2/2] fix test --- .../client/privateregistryclient/privateregistryclient_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/client/privateregistryclient/privateregistryclient_test.go b/internal/client/privateregistryclient/privateregistryclient_test.go index 8dc4c5db..0587dfbc 100644 --- a/internal/client/privateregistryclient/privateregistryclient_test.go +++ b/internal/client/privateregistryclient/privateregistryclient_test.go @@ -86,7 +86,7 @@ func TestValidateUpsertWorkflowInput(t *testing.T) { { name: "invalid status", input: OffchainWorkflowInput{WorkflowID: "wf", Status: "INVALID", WorkflowName: "w", BinaryURL: "b", DonFamily: "f"}, - err: "status must be one of \"WORKFLOW_STATUS_UNSPECIFIED\", \"WORKFLOW_STATUS_ACTIVE\", \"WORKFLOW_STATUS_PAUSED\"", + err: "status must be one of \"WORKFLOW_STATUS_ACTIVE\", \"WORKFLOW_STATUS_PAUSED\"", }, { name: "workflowName exceeds max length",