From 6b89e70f20fd12ebe509532b6eb4e22fc1aa30f3 Mon Sep 17 00:00:00 2001 From: Makram Kamaleddine Date: Mon, 24 Oct 2022 16:49:33 +0200 Subject: [PATCH 1/6] chore: remove maxGasPriceGWei from UI for VRF This job spec parameter is removed in https://github.com/smartcontractkit/chainlink/pull/7721 --- src/screens/Job/JobView.tsx | 1 - src/screens/Job/generateJobDefinition.test.ts | 2 -- src/screens/Job/generateJobDefinition.ts | 1 - 3 files changed, 4 deletions(-) diff --git a/src/screens/Job/JobView.tsx b/src/screens/Job/JobView.tsx index 3e269b3c..4cb71a7e 100644 --- a/src/screens/Job/JobView.tsx +++ b/src/screens/Job/JobView.tsx @@ -94,7 +94,6 @@ const JOB_PAYLOAD__SPEC = gql` requestTimeout backoffInitialDelay backoffMaxDelay - maxGasPriceGWei } ... on BlockhashStoreSpec { coordinatorV1Address diff --git a/src/screens/Job/generateJobDefinition.test.ts b/src/screens/Job/generateJobDefinition.test.ts index 6459244b..03eb1426 100644 --- a/src/screens/Job/generateJobDefinition.test.ts +++ b/src/screens/Job/generateJobDefinition.test.ts @@ -461,7 +461,6 @@ juelsPerFeeCoinSource = "1000000000" chunkSize: 25, backoffInitialDelay: '1m', backoffMaxDelay: '1h', - maxGasPriceGWei: 200, }, observationSource: ' fetch [type=http method=POST url="http://localhost:8001" requestData="{\\"hi\\": \\"hello\\"}"];\n parse [type=jsonparse path="data,result"];\n multiply [type=multiply times=100];\n fetch -> parse -> multiply;\n', @@ -487,7 +486,6 @@ batchFulfillmentGasMultiplier = 1 chunkSize = 25 backoffInitialDelay = "1m" backoffMaxDelay = "1h" -maxGasPriceGWei = 200 observationSource = """ fetch [type=http method=POST url="http://localhost:8001" requestData="{\\\\"hi\\\\": \\\\"hello\\\\"}"]; parse [type=jsonparse path="data,result"]; diff --git a/src/screens/Job/generateJobDefinition.ts b/src/screens/Job/generateJobDefinition.ts index 178f0816..132dca05 100644 --- a/src/screens/Job/generateJobDefinition.ts +++ b/src/screens/Job/generateJobDefinition.ts @@ -215,7 +215,6 @@ export const generateJobDefinition = ( 'chunkSize', 'backoffInitialDelay', 'backoffMaxDelay', - 'maxGasPriceGWei', ), ...extractObservationSourceField(job), } From 873bb18f1b0da0aefe9b6dfaedab49d40d2b47b8 Mon Sep 17 00:00:00 2001 From: Makram Kamaleddine Date: Mon, 24 Oct 2022 16:59:40 +0200 Subject: [PATCH 2/6] chore: add changeset --- .changeset/green-cherries-march.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/green-cherries-march.md diff --git a/.changeset/green-cherries-march.md b/.changeset/green-cherries-march.md new file mode 100644 index 00000000..7652266c --- /dev/null +++ b/.changeset/green-cherries-march.md @@ -0,0 +1,5 @@ +--- +'@smartcontractkit/operator-ui': minor +--- + +Remove maxGasPriceGWei from VRF job details page From e24c0137578b605f4c8584faacd60cf5f0a12eab Mon Sep 17 00:00:00 2001 From: Makram Kamaleddine Date: Mon, 24 Oct 2022 19:43:05 +0200 Subject: [PATCH 3/6] Revert "chore: add changeset" This reverts commit 873bb18f1b0da0aefe9b6dfaedab49d40d2b47b8. --- .changeset/green-cherries-march.md | 5 ----- 1 file changed, 5 deletions(-) delete mode 100644 .changeset/green-cherries-march.md diff --git a/.changeset/green-cherries-march.md b/.changeset/green-cherries-march.md deleted file mode 100644 index 7652266c..00000000 --- a/.changeset/green-cherries-march.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@smartcontractkit/operator-ui': minor ---- - -Remove maxGasPriceGWei from VRF job details page From e5dd8201e04d36b38275913578043e4a1812953d Mon Sep 17 00:00:00 2001 From: Makram Kamaleddine Date: Mon, 24 Oct 2022 19:46:08 +0200 Subject: [PATCH 4/6] chore: add changeset Set change kind to 'major'. --- .changeset/cyan-students-fold.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/cyan-students-fold.md diff --git a/.changeset/cyan-students-fold.md b/.changeset/cyan-students-fold.md new file mode 100644 index 00000000..d8e1dc59 --- /dev/null +++ b/.changeset/cyan-students-fold.md @@ -0,0 +1,6 @@ +--- +'@smartcontractkit/operator-ui': major +--- + +WHAT: Remove the `maxGasPriceGWei` field from VRF job details page. +WHY: `maxGasPriceGWei` is no longer a valid field for VRF jobs. From 719a774a52970cbc8e5e59b4c02315afbd3e2bb1 Mon Sep 17 00:00:00 2001 From: Makram Kamaleddine Date: Mon, 24 Oct 2022 21:31:28 +0200 Subject: [PATCH 5/6] Revert "chore: add changeset" This reverts commit e5dd8201e04d36b38275913578043e4a1812953d. --- .changeset/cyan-students-fold.md | 6 ------ 1 file changed, 6 deletions(-) delete mode 100644 .changeset/cyan-students-fold.md diff --git a/.changeset/cyan-students-fold.md b/.changeset/cyan-students-fold.md deleted file mode 100644 index d8e1dc59..00000000 --- a/.changeset/cyan-students-fold.md +++ /dev/null @@ -1,6 +0,0 @@ ---- -'@smartcontractkit/operator-ui': major ---- - -WHAT: Remove the `maxGasPriceGWei` field from VRF job details page. -WHY: `maxGasPriceGWei` is no longer a valid field for VRF jobs. From b585d45b9480d746297c5f226f1c8c1c1ebcff03 Mon Sep 17 00:00:00 2001 From: Makram Kamaleddine Date: Mon, 24 Oct 2022 21:32:23 +0200 Subject: [PATCH 6/6] chore: add changeset (minor this time) --- .changeset/dirty-eels-drive.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/dirty-eels-drive.md diff --git a/.changeset/dirty-eels-drive.md b/.changeset/dirty-eels-drive.md new file mode 100644 index 00000000..0813c362 --- /dev/null +++ b/.changeset/dirty-eels-drive.md @@ -0,0 +1,5 @@ +--- +'@smartcontractkit/operator-ui': minor +--- + +Remove the `maxGasPriceGWei` field from VRF job details page.