From e3e117a7b99db940fc6ea181775f99a0e4c725b8 Mon Sep 17 00:00:00 2001 From: george-dorin Date: Mon, 13 Feb 2023 14:44:57 +0200 Subject: [PATCH 1/3] Fix page size defaulting to 10 when set --- src/screens/Job/TabRuns.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/screens/Job/TabRuns.tsx b/src/screens/Job/TabRuns.tsx index 88feba10..3d9ab83e 100644 --- a/src/screens/Job/TabRuns.tsx +++ b/src/screens/Job/TabRuns.tsx @@ -20,7 +20,7 @@ export const TabRuns: React.FC = ({ fetchMore, job }) => { pageSize: number }>({ page: parseInt(params.get('page') || '1', 10), - pageSize: parseInt(params.get('per') || '10', 10), + pageSize: parseInt(params.get('size') || '10', 10), }) React.useEffect(() => { From 3042b00d3932b2d861fff7eca5e4c4dadc555091 Mon Sep 17 00:00:00 2001 From: george-dorin Date: Mon, 13 Feb 2023 15:41:25 +0200 Subject: [PATCH 2/3] Fix failing tests --- src/screens/Job/JobView.test.tsx | 2 +- src/screens/Job/TabRuns.test.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/screens/Job/JobView.test.tsx b/src/screens/Job/JobView.test.tsx index 9336f2a2..23f1a3d7 100644 --- a/src/screens/Job/JobView.test.tsx +++ b/src/screens/Job/JobView.test.tsx @@ -118,7 +118,7 @@ describe('JobView', () => { }, }) - renderComponent({ job, runsCount: 1 }, '/jobs/1/runs?page=1&per=1') + renderComponent({ job, runsCount: 1 }, '/jobs/1/runs?page=1&size=1') userEvent.click(getByRole('button', { name: /next-page/i })) diff --git a/src/screens/Job/TabRuns.test.tsx b/src/screens/Job/TabRuns.test.tsx index fc36e335..a46769c0 100644 --- a/src/screens/Job/TabRuns.test.tsx +++ b/src/screens/Job/TabRuns.test.tsx @@ -27,7 +27,7 @@ describe('TabRuns', () => { Run Page , - { initialEntries: [`/jobs/1/runs?page=${page}&per=${per}`] }, + { initialEntries: [`/jobs/1/runs?page=${page}&size=${per}`] }, ) } From 52cc5c6f14c63e0abe7e1208475dd036ef93d6de Mon Sep 17 00:00:00 2001 From: george-dorin Date: Tue, 14 Feb 2023 12:45:11 +0200 Subject: [PATCH 3/3] Add change set --- .changeset/thin-beers-peel.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/thin-beers-peel.md diff --git a/.changeset/thin-beers-peel.md b/.changeset/thin-beers-peel.md new file mode 100644 index 00000000..0c644549 --- /dev/null +++ b/.changeset/thin-beers-peel.md @@ -0,0 +1,5 @@ +--- +'@smartcontractkit/operator-ui': patch +--- + +Fix bug preventing selection of "Rows per page" in jobs/ID/runs page