feat: add solana worker type#153
Conversation
# Conflicts: # cmd/start.go # go.mod # go.sum
…g log polling on next PR)
There was a problem hiding this comment.
[noaction]
I don't know if the package structure allows it but, if we could place the EVM specific code in pkg/evm or pkg/timelock/evm subpackage, it would make the code base easier to navigate.
But we might run into import cycles, because the timelock worker implementation is not properly layered.
There was a problem hiding this comment.
[noaction]
another interesting refactor to consider: separating the worker instance from the listener service.
There was a problem hiding this comment.
yes good point, might be worth adding them as medium priority ticket to the maintainance epic
| pollSize: 1, | ||
| dryRun: false, | ||
| errContains: "parse \"://bad\"", | ||
| want: func(t *testing.T, w *WorkerSolana, err error) { |
There was a problem hiding this comment.
thanks. Just a tip for the future: a helper such as this can reduce some repetition, as the error checks are often pretty similar.
2 participants
Listen()functionstartCLI command.