feat: implement operation execution for the SolanaWorker type#157
Merged
gustavogama-cll merged 2 commits intoJun 5, 2025
Conversation
Base automatically changed from
ggama/feat-add-interfaces-make-scheduler-chain-family-agnostic
to
develop
May 29, 2025 18:22
gustavogama-cll
force-pushed
the
ggama/feat-add-solana-operation-execution
branch
5 times, most recently
from
1e9fff3 to
8b99a31
Compare
gustavogama-cll
force-pushed
the
ggama/feat-add-solana-operation-execution
branch
from
8834869 to
760b5aa
Compare
ecPablo
previously approved these changes
Jun 4, 2025
ChrisAmora
previously approved these changes
Jun 5, 2025
gustavogama-cll
commented
Jun 5, 2025
| With(eventTarget, event.Target.String()). | ||
| With(operationID, fmt.Sprintf("%x", event.ID)) | ||
|
|
||
| if event.Index > 0 { |
Contributor
Author
There was a problem hiding this comment.
this is an important change relative to EVM: we only process the event with index == 0. That's because the execute function is able to build the payload from all transactions in an mcms.BatchOperation by querying the timelock's "operation pda". And by processing only the first event, it's easier to ensure the timelock-worker executes the transaction in the correct order.
Contributor
Author
|
Thanks @ecPablo . I'm afraid I'll need another approval as I had to push an update adjusting the logic of the main |
ChrisAmora
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.