From 15cd8118df821c26ed04b5175801a4e770e90513 Mon Sep 17 00:00:00 2001 From: seroze Date: Sun, 9 Aug 2026 23:42:35 +0000 Subject: [PATCH] refactor(naive_bayes): remove duplicated RealNumber trait bound `GaussianNB` declared `TX: Number + RealNumber + RealNumber` in four places (the struct and its Display, SupervisedEstimator and Predictor impls). The repeated bound is a no-op, so this is purely cosmetic. rustfmt collapses the now-shorter generic lists onto one line. --- src/naive_bayes/gaussian.rs | 26 +++++++------------------- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/src/naive_bayes/gaussian.rs b/src/naive_bayes/gaussian.rs index 8ce6e64d..51d45b93 100644 --- a/src/naive_bayes/gaussian.rs +++ b/src/naive_bayes/gaussian.rs @@ -260,7 +260,7 @@ impl GaussianNBDistribution { #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] #[derive(Debug, PartialEq)] pub struct GaussianNB< - TX: Number + RealNumber + RealNumber, + TX: Number + RealNumber, TY: Number + Ord + Unsigned, X: Array2, Y: Array1, @@ -268,12 +268,8 @@ pub struct GaussianNB< inner: Option>>, } -impl< - TX: Number + RealNumber + RealNumber, - TY: Number + Ord + Unsigned, - X: Array2, - Y: Array1, -> fmt::Display for GaussianNB +impl, Y: Array1> + fmt::Display for GaussianNB { fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { writeln!(f, "GaussianNB:\ninner: {:?}", self.inner.as_ref().unwrap())?; @@ -281,12 +277,8 @@ impl< } } -impl< - TX: Number + RealNumber + RealNumber, - TY: Number + Ord + Unsigned, - X: Array2, - Y: Array1, -> SupervisedEstimator for GaussianNB +impl, Y: Array1> + SupervisedEstimator for GaussianNB { fn new() -> Self { Self { @@ -299,12 +291,8 @@ impl< } } -impl< - TX: Number + RealNumber + RealNumber, - TY: Number + Ord + Unsigned, - X: Array2, - Y: Array1, -> Predictor for GaussianNB +impl, Y: Array1> + Predictor for GaussianNB { fn predict(&self, x: &X) -> Result { self.predict(x)