-
Notifications
You must be signed in to change notification settings - Fork 24
Release 5.0.0 #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 5.0.0 #130
Conversation
Files OnEmergencyEvent, OnPhoneCall were deleted. OnEventChanged file was created. PHONE_CALL, EMERGENCY_EVENT, DEACTIVATE_HMI, AUDIO_SOURCE, EMBEDDED_NAVI events were described in OnEventChanged file. Appropriate tables and diagrams were added.
OnEventChanged index was added
The list of affected RPCs was updated
Add LowVoltage index Add low_voltage diagram
Add FuelRange struct
Add FuelType enum element VEHICLEDATA_FUELRANGE to VehicleDataType
Add fuelRange, engineOilLife parameters
Add fuelRange, engineOilLife params
Add VEHICLEDATA_ENGINEOILLIFE to VehicleDataType
Add fuelRange, engineOilLife params to request and response
Add fuelRange, engineOilLife params to request and response
OnEventChanged
…lectronic_park_brake_status Add TurnSignal and ElectronicParkBrakeStatus to vehicle data
Add secondaryDeviceInfo parameter
Add displayName parameter to DisplayCapabilities
…ditions Add new tire pressure parameters
* Add audioStreamingIndicator to SetMediaClockTimer
* Add note to image regarding invalid references
Add missing secondaryGraphic ImageFieldName
…chemes Add template color schemes
Addition of PLAY_PAUSE definition in ButtonName enum
Add missing PRNDL enum
Remove unused AllowDeviceToConnect
|
Preview this pull request at https://smartdevicelink.com/en/docs/pull_request/bf41a647c746fe4d52836544e242ac61812e4faa/overview/ |
|
Preview this pull request at https://smartdevicelink.com/en/docs/pull_request/cc74a8357974f295a79e6d7ffb9044c823cff984/overview/ |
Change ApplicationToNONEReason to ApplicationExitReason
|
Preview this pull request at https://smartdevicelink.com/en/docs/pull_request/2b66bdcfe59b9f44a570112db83a3436de09fb83/overview/ |
theresalech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a few formatting comments for you to review. Please let me know of any questions, thanks!
docs/RC/OnRCStatus/index.md
Outdated
| Purpose | ||
| : Inform HMI and mobile application about changes in RC module allocation. | ||
|
|
||
| !!! must |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this either needs to be removed, or !!! should be added to the end of the must block.
docs/UI/SetMediaClockTimer/index.md
Outdated
|
|
||
| 3) Respond with the [result code] correspondingly to the results of this RPC execution. | ||
| [result code]: https://github.com/smartdevicelink/sdl_hmi_integration_guidelines/blob/develop/docs/UI/SetMediaClockTimer/index.md#response | ||
| 1. perform the update type indicated by the `updateMode` parameter: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be nice to capitalize Perform to match the other formatting in this document.
docs/UI/SetMediaClockTimer/index.md
Outdated
| 1. perform the update type indicated by the `updateMode` parameter: | ||
| * If the application is not active, the HMI must still store the values to be calculated for later display on the HMI. | ||
| * If the application is active, the updates must begin immediately. | ||
| 2. exhibit the following behavior based on the `updateMode` parameter: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be nice to capitalize Exhibit to match the other formatting in this document.
docs/UI/SetMediaClockTimer/index.md
Outdated
|
|
||
| !!! NOTE | ||
| 1) SDL will not send this request if the `mediaClock` field is not indicated as supported in [UI.GetCapabilities](https://github.com/smartdevicelink/sdl_hmi_integration_guidelines/blob/master/docs/UI/GetCapabilities/index.md). | ||
| 1) SDL will not send this request if the `mediaClock` field is not indicated as supported in [UI.GetCapabilities](../getcapabilities). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list should be updated to 1., 2., 3. as the parentheses don't format properly here: https://smartdevicelink.com/en/docs/pull_request/2b66bdcfe59b9f44a570112db83a3436de09fb83/ui/setmediaclocktimer/
|
|
||
| !!! | ||
|
|
||
| _Note:_ SDL logs the corresponding error internally and fails the handshake process if at least one of the following failures occurs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be formatted as a !!! NOTE ?
|
@theresalech addressed review comments in f9a17cd |
|
Preview this pull request at https://smartdevicelink.com/en/docs/pull_request/f9a17cd7203dcd49d320406be9a77fc94422c449/overview/ |
Documentation updates for Core release 5.0.0