Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App icon upload fails on reconnection to the head unit #1013

Closed
Lievesley opened this issue Jul 4, 2018 · 2 comments

Comments

@Lievesley
Copy link

commented Jul 4, 2018

Bug Report

App icon upload only succeeds on the first connection to the head unit. This is because SDLFile is not reusable. The NSInputStream is not recreated which means nothing can be uploaded.

Reproduction Steps
  1. Connect iPhone to Head Unit with USB cable.
  2. App icon is displayed.
  3. Disconnect iPhone.
  4. Connect iPhone again.
  5. App icon is no longer shown one Head Unit because the app icon's SDLFile input stream has no bytes available.
Expected Behaviour

App icon should be uploaded on each connection.

Observed Behaviour

App icon upload fails with unknown error.

OS & Version Information
  • iOS Version: 11.3
  • SDL iOS Version: 5.2
  • Testing Against: 5.2
@NicoleYarroch

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2018

This bug has been noted and fixed in PR #991.

@NicoleYarroch NicoleYarroch referenced this issue Jul 10, 2018
10 of 10 tasks complete

@joeljfischer joeljfischer added this to the 6.0.1 milestone Jul 10, 2018

@joeljfischer joeljfischer added the bug label Jul 10, 2018

@Lievesley Lievesley closed this Jul 12, 2018

@Lievesley Lievesley reopened this Jul 12, 2018

@Lievesley

This comment has been minimized.

Copy link
Author

commented Jul 12, 2018

While this issue is also fixed also in PR #991 I also recommend a small refactoring change to improve clarity which is in PR #1015

@joeljfischer joeljfischer modified the milestones: 6.0.1, 6.1.0 Jul 24, 2018

@joeljfischer joeljfischer added this to Bug Backlog in v6.1.0 Jul 24, 2018

@joeljfischer joeljfischer referenced this issue Aug 16, 2018
3 of 3 tasks complete

v6.1.0 automation moved this from Bug Backlog to Done Aug 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.