Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets are not downloaded when using `.../Swift` to install library via CocoaPods #1026

Closed
NicoleYarroch opened this issue Jul 13, 2018 · 12 comments

Comments

@NicoleYarroch
Copy link
Contributor

commented Jul 13, 2018

Bug Report

The lock screen assets are not downloaded when using SmartDeviceLink/Swift to install the library via CocoaPods. This causes a crash if the developer is using the default lock screen.

Reproduction Steps
  1. Install library in project using pod 'SmartDeviceLink/Swift', '~> 6.0'.
  2. Use the default lock screen when setting up theSDLConfiguration.
  3. Connect to a head unit.
Expected Behavior

The app should not crash

Observed Behavior

The app crashes

OS & Version Information
  • iOS Version: n/a
  • SDL iOS Version: 6.0 and probably previous versions
  • Testing Against: n/a

@NicoleYarroch NicoleYarroch added the bug label Jul 13, 2018

@NicoleYarroch NicoleYarroch added this to the BugFixes milestone Jul 13, 2018

@MichaelCrimando

This comment has been minimized.

Copy link

commented Aug 7, 2018

Hmm, so is it possible to get a lock screen working on a swift project? We were hitting issues with this

@NicoleYarroch

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2018

@MichaelCrimando pod SmartDeviceLink/Swift is only if you want to add custom SDL logging to a Swift project. Use pod 'SmartDeviceLink' for both Swift and Obj-C projects.

@rbright55

This comment has been minimized.

Copy link

commented Aug 15, 2018

Added both pods to the project. Crash occurs when using CarWindow with the lockscreen enabled.

@NicoleYarroch

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2018

@rbright55 What kind of error are you seeing in the Xcode debug logs? Is it crashing because the lock screen assets are not in the project or for some other reason?

@rbright55

This comment has been minimized.

Copy link

commented Aug 15, 2018

@NicoleYarroch I added both pod 'SmartDeviceLink','~> 6.0.1' and pod 'SmartDeviceLink/Swift','~> 6.0.1' which added the lock screen assets.
The crash comes when the app tries to dismiss the lock screen.

@NicoleYarroch

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2018

@rbright55 Are you using the default lock screen configuration or a custom lock screen config? I'm not seeing any issues with the the default lock screen and CarWindow in v.6.0.1. What error message do you get on crash?

@rbright55

This comment has been minimized.

Copy link

commented Aug 15, 2018

The error message says Thread 1: EXC_BAD_ACCESS (code=1, address=0x110260000)
screen shot 2018-08-15 at 1 17 55 pm

@NicoleYarroch

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2018

I think the crash is happening because the imageWidth (375) and imageHeight (618) are different from the imageRefs width and height (800, 348). Does your rootViewController subclass the SDLCarWindowViewController?

@rbright55

This comment has been minimized.

Copy link

commented Aug 15, 2018

yes it is a SDLCarWindowViewController

@NicoleYarroch

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2018

Are you setting the CarWindows rootViewController in a viewDidLoad or viewWillAppear method? If not, where are you setting it?

@rbright55

This comment has been minimized.

Copy link

commented Aug 15, 2018

It is set in the viewDidAppear method

@NicoleYarroch

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2018

Hmm. I'm not sure what is causing the crash then. I need more detail about what is happening. Can we move this discussion to the iOS SDL slack channel (http://slack.smartdevicelink.com)?

  1. Are you connecting to a TDK via iAP or to an emulator via TCP?
  2. The default configuration lock screen is showing correctly, but it crashes when dismissed with an OnDriverDistraction notification?
  3. Did you rotate the device before the lock screen was dismissed?
  4. Is the rootViewController a mirror of what is being displayed on the phone app or is it an off-screen view controller?

@joeljfischer joeljfischer modified the milestones: BugFixes, 6.1.0 Aug 27, 2018

@joeljfischer joeljfischer added this to In Review in v6.1.0 Aug 27, 2018

v6.1.0 automation moved this from In Review to Done Sep 5, 2018

@joeljfischer joeljfischer referenced this issue Sep 5, 2018
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.