New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash NSRangeException #1076

Closed
mvyrko opened this Issue Sep 17, 2018 · 0 comments

Comments

Projects
2 participants
@mvyrko

mvyrko commented Sep 17, 2018

Bug Report

sdl_abortOperationWithRequest called when an operation is isCancelled but not is isFinished, and try to call progressHandler in a for-each cycle then try to get a request for the array by index is equal requests.count (out of the range).

self.progressHandler(self.requests[i], nil, [NSError sdl_lifecycle_multipleRequestsCancelled], self.percentComplete);

Reproduction Steps
  1. Create SDLAsynchronousRPCRequestOperation with few requests
  2. Run operation
  3. Call cancel for operation before it is finished
Expected Behavior

No crash and progressHandler for all requests

Observed Behavior

Crash

OS & Version Information
  • iOS Version: Any
  • SDL iOS Version: 5.2.0 to the 6.0.2
  • Testing Against: Crash
Test Case, Sample Code, and / or Example App

@mvyrko mvyrko referenced this issue Sep 17, 2018

Closed

fix of crash NSRangeException #1077

1 of 1 task complete

@joeljfischer joeljfischer added this to the 6.1.0 milestone Sep 17, 2018

@joeljfischer joeljfischer added the bug label Sep 17, 2018

@joeljfischer joeljfischer added this to Done in v6.1.0 via automation Sep 19, 2018

@joeljfischer joeljfischer referenced this issue Sep 19, 2018

Merged

v6.1.0 Release #999

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment