Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash occurs in SDLLifecycleManager#didEnterStateRegistered #1127

Closed
t-yoshii opened this issue Nov 13, 2018 · 0 comments
Closed

Crash occurs in SDLLifecycleManager#didEnterStateRegistered #1127

t-yoshii opened this issue Nov 13, 2018 · 0 comments

Comments

@t-yoshii
Copy link

t-yoshii commented Nov 13, 2018

Bug Report

Crash occurs in SDLLifecycleManager#didEnterStateRegistered when the self.registerResponse.language = ‘-1’.

isEaualToEnum call for ‘-1’ (NSInteger) cause a crash.
https://github.com/smartdevicelink/sdl_ios/blob/master/SmartDeviceLink/SDLLifecycleManager.m#L316

registerResponse.language must be NSString, however, SDL Core can send ‘-1’ (INVALID_ENUM) when HMI returns invalid language for VR and TTS.
Related issue:
smartdevicelink/sdl_core#2230

Reproduction Steps
  1. Connect SDL Proxy with HU which has invalid language value.
Expected Behavior

Crash does not occur

Observed Behavior

Crash occurs

OS & Version Information
  • iOS Version: all
  • SDL iOS Version: v6.1.1
  • Testing Against: Our internal devboard
Test Case, Sample Code, and / or Example App

I will create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant