Adding missing conditional check to stop the manager if SDLAppInterfa…

[justingluck93]

Fixes #1097 WIP

This PR is ready for review.

Risk

This PR makes no API changes.

Summary

Added protocol violation check to the if conditional to stop the manager

CLA

• I have signed the CLA

[NicoleYarroch]

I can still reproduce the bug when connecting to sdl_core.

1. Connect SDL_iOS swift example app to sdl_core (v. 5.1.0) + sdl_hmi (develop).
2. Open the menu on the sdl app and select the "Exit 'UNAUTHORIZED_TRANSPORT_REGISTRATION'" menu item. This will send an OnAppInterfaceUnregistered RPC with a reason code of APP_UNAUTHORIZED.
3. The app will disconnect and then automatically reconnect to Core.

The issue is that the SDLProxy class is intercepting the OnAppInterfaceUnregistered RPC and sending a SDLTransportDidDisconnect notification before it broadcasts the OnAppInterfaceUnregistered RPC. The SDLLifecycleManager gets the SDLTransportDidDisconnect notification first and then the OnAppInterfaceUnregistered notification when it should be the other way around.

To fix this, in the handleRPCDictionary: method of the SDLProxy class, move:

if ([functionName isEqualToString:SDLRPCFunctionNameOnAppInterfaceUnregistered] || [functionName isEqualToString:SDLRPCFunctionNameUnregisterAppInterface]) {
    [self handleRPCUnregistered:dict];
}

to after this line:

[self sdl_invokeDelegateMethodsWithFunction:functionName message:newMessage];

[NicoleYarroch]

I can still reproduce the issue. I left a comment with instructions on how to reproduce and with some steps you can take to investigate the issue.

[justingluck93]

This PR is just to get the check inside the LifeCycle it does not completely fix the issue yet. The underlining issue is still being investigated. I will use your steps and see if I can track down a fix.