Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to compile if the ProxyManager is in objective c++ #1478

Closed
ed-h opened this issue Nov 27, 2019 · 3 comments
Closed

Unable to compile if the ProxyManager is in objective c++ #1478

ed-h opened this issue Nov 27, 2019 · 3 comments
Assignees
Labels
bug

Comments

@ed-h
Copy link

@ed-h ed-h commented Nov 27, 2019

Bug Report

Due to our project needs, our proxy manager is in objective c++, this will cause compile error due to the template keyword that is used in SDLTemplateConfiguration.h.
This wasn't an issue in older version since SDLTemplateConfiguration class is added in 6.4.0

Reproduction Steps
  1. Rename ProxyManager.m to ProxyManager.mm so it will be compiled as objective c++
  2. Import SmartDeviceLink.h as documented
  3. Compile error will occur.
    Pods/Headers/Public/SmartDeviceLink/SDLTemplateConfiguration.h:40:46: error: expected identifier; 'template' is a keyword in Objective-C++

Pods/Headers/Public/SmartDeviceLink/SDLTemplateConfiguration.h:45:41: error: expected member name or ';' after declaration specifiers; 'template' is a keyword in Objective-C++
@Property (strong, nonatomic) NSString *template;

Suggest to rename this variable to templateName instead of template

Expected Behavior

Project should compile fine.

Observed Behavior

Compoile failed

OS & Version Information

Xcode 11.2.1
SDL iOS SDK 6.4.0/6.4.1

@alekseypotapov-dev
Copy link
Contributor

@alekseypotapov-dev alekseypotapov-dev commented Dec 2, 2019

I have the same issue.

@joeljfischer
Copy link
Member

@joeljfischer joeljfischer commented Dec 9, 2019

@ed-h @Braves We have a bug fix in the PR #1485. Could you please verify that branch fixes your bugs? It may be a few weeks before release due to the holidays and CES, but until that point, hopefully you can continue development using the provided PR and branch.

@alekseypotapov-dev
Copy link
Contributor

@alekseypotapov-dev alekseypotapov-dev commented Dec 19, 2019

@joeljfischer sorry for late response. This fix works for me just fine, thank you!

@joeljfischer joeljfischer mentioned this issue Jan 7, 2020
3 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants