Setting SDLTouchManager.tapTimeThreshold to 0.0 causes a debug crash

[joeljfischer]

Bug Report

Setting tapTimeThreshold to 0.0 is necessary to disable double taps, however, we have an assertion that doesn't allow a 0.0 tap time threshold.

Reproduction Steps

1. Set tapTimeThreshold to 0.0 in a video streaming app
2. Tap the screen a few times

Expected Behavior

The taps work properly as single taps

Observed Behavior

The taps cause a crash

OS & Version Information

• iOS Version: n/a
• SDL iOS Version: 7.0.0-develop
• Testing Against: Sync Gen 3.4-dev

Test Case, Sample Code, and / or Example App

The fix is:

- (void)sdl_initializeSingleTapTimerAtPoint:(CGPoint)point {
    if (self.singleTapTimer != nil) {
        [self sdl_cancelSingleTapTimer];
    }

    if (self.tapTimeThreshold == 0.0) {
        [self sdl_singleTapTimerCallbackWithPoint:point];
    } else {
        __weak typeof(self) weakSelf = self;
        self.singleTapTimer = [[SDLTimer alloc] initWithDuration:self.tapTimeThreshold];
        self.singleTapTimer.elapsedBlock = ^{
            [weakSelf sdl_singleTapTimerCallbackWithPoint:point];
        };
        [self.singleTapTimer start];
    }
}