Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu updates fail if updates are queued #1957

Closed
NicoleYarroch opened this issue Apr 1, 2021 · 0 comments · Fixed by #1901
Closed

Menu updates fail if updates are queued #1957

NicoleYarroch opened this issue Apr 1, 2021 · 0 comments · Fixed by #1901
Assignees
Labels
bug A defect in the library manager-screen Relating to the manager layer - screen managers
Projects

Comments

@NicoleYarroch
Copy link
Contributor

NicoleYarroch commented Apr 1, 2021

Bug Report

The SDLMenuManager fails to create a new menu correctly if a new menu is replacing a menu that has not yet finished uploading. The new menu update is queued because the first menu has not yet finished uploading. Once the initial menu has finished uploading, the new, queued, menu is sent. However, there is a bug in the sending the queued menu because the old menu cells are sent instead of the new menu cells.

Reproduction Steps
  1. Create a menu. Make the first menu cell update with a new menu whenever selected.
  2. Connect the SDL app to the module. Open the menu and select the first menu item. The menu should update. Before the menu update finishes, open the menu and select the first menu cell again.
  3. Close and reopen the menu
Expected Behavior

The expected menu from step no. 2 should show up.

Observed Behavior

The menu from step one has not be deleted and a menu item(s) from step 1 might be in the list.

OS & Version Information
  • iOS Version: n/a
  • SDL iOS Version: 7.1
  • Testing Against: SYNC 3
@NicoleYarroch NicoleYarroch added bug A defect in the library manager-screen Relating to the manager layer - screen managers labels Apr 1, 2021
@NicoleYarroch NicoleYarroch self-assigned this Apr 1, 2021
@NicoleYarroch NicoleYarroch added this to To do in v7.1.0 via automation Apr 1, 2021
@NicoleYarroch NicoleYarroch changed the title Menu updates fail if HMI level or system context changes Menu updates fail if updates are queued Apr 6, 2021
@NicoleYarroch NicoleYarroch linked a pull request Apr 6, 2021 that will close this issue
6 tasks
@joeljfischer joeljfischer removed this from To do in v7.1.0 Apr 14, 2021
@joeljfischer joeljfischer linked a pull request Aug 23, 2021 that will close this issue
4 tasks
@joeljfischer joeljfischer added this to To do in v7.3.0 via automation Aug 25, 2021
v7.3.0 automation moved this from To do to Done Sep 24, 2021
@joeljfischer joeljfischer mentioned this issue Sep 27, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library manager-screen Relating to the manager layer - screen managers
Projects
No open projects
2 participants