New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PLAY_PAUSE to ButtonName enum #246

Closed
justinjdickow opened this Issue Jun 29, 2015 · 7 comments

Comments

Projects
3 participants
@justinjdickow
Contributor

justinjdickow commented Jun 29, 2015

No description provided.

@justinjdickow justinjdickow added this to the 4.1.0 milestone Jun 29, 2015

@justinjdickow

This comment has been minimized.

Contributor

justinjdickow commented Jul 31, 2015

Need to go back to #146 to check if PLAY_PAUSE is a 4.0.0 RPC change.

@joeljfischer

This comment has been minimized.

Member

joeljfischer commented Jul 29, 2016

@justinjdickow do you know what's up with this issue?

@joeljfischer

This comment has been minimized.

Member

joeljfischer commented Oct 14, 2016

@joeljfischer

This comment has been minimized.

Member

joeljfischer commented Feb 10, 2017

This needs to wait for a major version change of the RPC spec.

@kshala-ford

This comment has been minimized.

Contributor

kshala-ford commented Apr 28, 2017

@joeljfischer any update to the PLAY_PAUSE feature? Anyhting that need to be done beforehand?

@joeljfischer

This comment has been minimized.

Member

joeljfischer commented Apr 28, 2017

@kshala-ford As noted above, this needs to wait for a major version rev of the RPC spec.

@joeljfischer

This comment has been minimized.

Member

joeljfischer commented Apr 28, 2017

@kshala-ford I'm looking around for exactly why (it's been a while), and you may have to ask @joeygrover for the exact reason, I don't see it documented. smartdevicelink/sdl_core#766

@joeljfischer joeljfischer modified the milestones: Future, 4.X May 2, 2017

@joeljfischer joeljfischer referenced this issue Sep 12, 2018

Merged

Add Play/Pause to ButtonName #1075

5 of 5 tasks complete

@joeljfischer joeljfischer modified the milestones: Future, 6.1.0 Sep 12, 2018

@joeljfischer joeljfischer self-assigned this Sep 12, 2018

@joeljfischer joeljfischer added this to In Progress in v6.1.0 Sep 14, 2018

v6.1.0 automation moved this from In Progress to Done Sep 19, 2018

@joeljfischer joeljfischer referenced this issue Sep 19, 2018

Merged

v6.1.0 Release #999

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment