New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDL 0099] New remote control modules (LIGHT, AUDIO, HMI_SETTINGS) and parameters (SIS Data) #755

Closed
theresalech opened this Issue Oct 2, 2017 · 3 comments

Comments

Projects
3 participants
@theresalech
Contributor

theresalech commented Oct 2, 2017

Proposal: New remote control modules (LIGHT, AUDIO, HMI_SETTINGS) and parameters (SIS Data)

SDL remote control provides the ability for mobile applications to control certain components of the vehicle, such as, tune the radio, set the desired temperature or change the fan speed. However, currently only CLIMATE and RADIO modules are available for remote-control. Mobile application developers need more than basic climate or radio control. To meet developers' requirements, we propose to add three new modules (AUDIO, LIGHT, HMI_SETTINGS) and some new parameters (heatedXXXEnable and radio sisData) to the existing CLIMATE and RADIO modules respectively. This proposal only defines new data types and new parameters added to the existing data types. It does not add or change any remote control RPCs.

Review: smartdevicelink/sdl_evolution#296

Steering Committee Decision:

The Steering Committee voted to accept this proposal with revisions. The author will revise the proposal to fix a few typos, as well as include descriptions for the groups of lights - listing which single light elements they typically include. It was also noted that limiting the scope of proposals, especially those related to Remote Control, in the future will help to make for easier understanding and discussion among SDLC Members.
Proposal has now been revised to include the descriptions and fix the typos mentioned.

@theresalech

This comment has been minimized.

Contributor

theresalech commented Jul 11, 2018

This feature is revised by SDL 0182

@theresalech

This comment has been minimized.

Contributor

theresalech commented Aug 13, 2018

Proposal markdown file has been updated per the revisions included in accepted Evolution Proposal Revise SDL-0099 - New remote control modules. Implementation will need to be revised to remove the duplicate structs and reuse GPSData and RGBColor.

@joeljfischer I believe this change is already incorporated in this implementation. Can you please confirm?

@jordynmackool

This comment has been minimized.

jordynmackool commented Oct 3, 2018

Proposal file has been updated per the revisions in this accepted PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment