Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the lock screen configuration's show in optional state #1073

Conversation

@NicoleYarroch
Copy link
Contributor

commented Sep 7, 2018

Fixes #1070

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Test cases added to SDLLockScreenManagerSpec to test the SDLLockScreenStatusOptional state.

Summary

If the lock screen configuration's showInOptionalState is set to true, the lock screen is now not dismissed when the app is in the "lock screen optional" state.

Changelog

Enhancements
  • The lock screen configuration's showInOptionalState now works as expected.

Tasks Remaining:

  • Test enabled state with showInOptionalState set to true with Manticore and SYNC3
  • Test enabled state with showInOptionalState set to false with Manticore and SYNC3

CLA

Updated lock screen documentation for `showInOptionalState`

Signed-off-by: NicoleYarroch <nicole@livio.io>
* added test cases

Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
@NicoleYarroch NicoleYarroch changed the base branch from master to develop Sep 7, 2018
@NicoleYarroch NicoleYarroch requested a review from joeljfischer Sep 7, 2018
@NicoleYarroch NicoleYarroch self-assigned this Sep 7, 2018
@NicoleYarroch NicoleYarroch added the bug label Sep 7, 2018
@NicoleYarroch NicoleYarroch added this to the 6.1.0 milestone Sep 7, 2018
* @param previousHMILevel The previous `hmiLevel`
* @return True if currently if the "lock screen optional" state; false if not
*/
+ (BOOL)sdl_inLockScreenOptionalStateForLockScreenStatus:(nullable SDLOnLockScreenStatus *)lockScreenStatus previousHMILevel:(nullable SDLHMILevel)previousHMILevel {

This comment has been minimized.

Copy link
@joeljfischer

joeljfischer Sep 7, 2018

Member

Much of this logic already exists in SDLLockScreenStatusManager. Did you trace how the SDLOnLockScreenStatus notification works?

This comment has been minimized.

Copy link
@NicoleYarroch

NicoleYarroch Sep 11, 2018

Author Contributor

Should be fixed.

Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
@joeljfischer joeljfischer merged commit ba71c66 into develop Sep 14, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@NicoleYarroch NicoleYarroch deleted the bugfix/issue_1070_lock_screen_visibility_can_not_be_toggled branch Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.