5.2.0 Release #1709
Merged
5.2.0 Release #1709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add NPE check in BaseChoiceSetManager
Co-authored-by: Henigan <rheniga1@MGC12Z921DLVCG.fbpld77.ford.com>
Co-authored-by: Henigan <rheniga1@MGC12Z921DLVCG.fbpld77.ford.com>
…choices" This reverts commit 19498a9.
Fix for Two voiceCommands contains the same string
Will only start the listener if the BT device is not null, or in the case where the SDL app is the only app installed.
* Make SdlPSM more robust Add more checks that will help the PSM churn through bad data to get back on track. Also add a try/catch block for each attempt to prevent any production crashes. * Overhaul SdlPsm unit tests and add more * Update base/src/main/java/com/smartdevicelink/transport/SdlPsm.java Co-authored-by: Julian Kast <Julian.kast@livio.io> Co-authored-by: Julian Kast <Julian.kast@livio.io>
…sten_during_connection Allow SdlDeviceListener to start after BT connection
Move exception reporting to debugtool
…n BaseVoiceCommandManger and VoiceCommandUpdateOperation
* Update sending VoiceCommandManager to strip extra whiteSpace from voiceCommands and avoid sending empty strings in the update operation * Add unit test for empty strings and trimmed whiteSpace for voiceCommands * update unit test * Add null unit test check to voiceCommandManager * Implement suggestions from code review * Removed null voiceCommands from VoiceCommandList. Update unit test * Fix suggestions from code review * Update ID's for voice commands in proper list * Strip white Space before checking if commands are unique Co-authored-by: Julian Kast <julian@livio.com>
… voiceCommands in VoiceCommandManager
…st to test new logic correctly
* Add workaround to solve issue 1690 * Add unit tests for the workaround
Fix to avoid deleting and setting identical voice commands
Add onClose callbacks after LCM clean() calls
* Fix Non-Media Sync template bug in BaseSystemCapabilityManager * Add unit test for sync bug for NON_MEDIA template Co-authored-by: Julian Kast <julian@livio.com>
…lable into account for uniqueness (#1684) * BaseChoiceSetManager, Strip away unsupported textFields from choices * Add image checking to ChoiceSetManager uniqueness check * MenuManager strip parameters away from uniqueness check if hmi does not support fields * added logic to check subcells properly * Add missing ! * Fix copy paste error with naming * Clone choiceCell when comparing for visual uniqueness * Clone menuCell when comparing for visual uniqueness * update comment * Add check for submenu * Refactor check for uniqueness * Add WindowCapability to menuManagerTest * Change menuCellsAreUnique to package private and add unit test * Update unit test * add menuManager test * Clean up BaseChoiceSetManager logic * Add more unit test * Modify menu manger unit test * Formatting and cleanup of unitTest * Added logic for : On RPC v7.1+ connections, we will no longer display duplicate menu cells if some property of the cell is different but that property isn't actually displayed on the head unit. * Remove testing logic that was not meant to be uploaded. * Fix not checking available ChoiceCell properties * Add null checks and remove added unitTest, * Fix subCell logic for MenuCells * Add unit test to menuManager * Remove testing code and add unit test for the choiceSetManager * Update comments/alignment * remove unused import Co-authored-by: Julian Kast <julian@livio.com>
…ceived where DismissalEnabled is false (#1699) * Fix corner case in LockScreenManager * Update unit tests
Fix MenuManager sending secondary image with menuCells when menuCommandSecondaryImage is not supported
Codecov Report
@@ Coverage Diff @@
## master #1709 +/- ##
============================================
+ Coverage 53.94% 54.45% +0.50%
- Complexity 5305 5406 +101
============================================
Files 555 555
Lines 24561 24746 +185
Branches 3101 3156 +55
============================================
+ Hits 13249 13475 +226
+ Misses 10160 10096 -64
- Partials 1152 1175 +23
|
* Fix testTouchEvents() * Add workflow_dispatch CI trigger
JulianKast
approved these changes
Jun 29, 2021
Contributor
JulianKast
left a comment
JulianKast
left a comment
There was a problem hiding this comment.
Approved, @bilal-alsharifi should review my additions before moving forward.
Contributor
Author
|
@JulianKast latest changes look good 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Summary
See the 5.2.0 Project
Bintray / Gradle:
(These will be updated as seen fit if there are changes)
Android:
implementation 'com.smartdevicelink:sdl_android:RC_5.2.0'JavaSE:
implementation 'com.smartdevicelink:sdl_java_se:RC_5.2.0'JavaEE:
implementation 'com.smartdevicelink:sdl_java_ee:RC_5.2.0'CLA