Skip to content

Conversation

@bilal-alsharifi
Copy link
Contributor

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android

Core Tests

  • Send a SetDisplayLayout without a template
  • Make sure the app doesn't crash

Core version / branch / commit hash / module tested against: 7.1.1

Summary

This PR fixes a potential NPE in LifecycleManager if the app sends a SetDisplayLayout without setting a template. This scenario shouldn't happen in real life because a template is required but it shoud still not crash the app.

CLA

@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #1710 (ada2fd5) into release/5.2.0_RC (2ac4eae) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             release/5.2.0_RC    #1710   +/-   ##
===================================================
  Coverage               54.45%   54.46%           
- Complexity               5405     5407    +2     
===================================================
  Files                     555      555           
  Lines                   24746    24746           
  Branches                 3156     3156           
===================================================
+ Hits                    13476    13478    +2     
+ Misses                  10097    10095    -2     
  Partials                 1173     1173           
Impacted Files Coverage Δ
...elink/managers/lifecycle/BaseLifecycleManager.java 14.07% <100.00%> (ø)
...ink/managers/screen/BaseTextAndGraphicManager.java 64.16% <0.00%> (+0.41%) ⬆️
...rtdevicelink/streaming/video/SdlRemoteDisplay.java 51.21% <0.00%> (+1.21%) ⬆️

@JulianKast JulianKast merged commit 6c55685 into release/5.2.0_RC Jun 28, 2021
@JulianKast JulianKast deleted the bugfix/fix_lcm_npe branch June 28, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants